Closed mattxwang closed 3 years ago
Wow, thanks @mattxwang! It doesn't sound like there's any reason to wait merging this, as long as you're confident everything (that worked previously) is still working. Right?
By the way: have you checked out https://imagej.github.io? We're nearly done rebuilding the ImageJ wiki in GitHub Pages. As part of that, we are in the process of integrating some parts of this fiji.sc splash site onto the imagej.github.io (which will become imagej.net when we reach production stage) front page. Not sure what the long-term fate of this fiji.sc splash page will be; it might make sense to make some changes to better integrate it with the content at https://imagej.github.io/fiji? Not sure yet. Suggestions and ideas welcome.
Oops, sorry for the late turnaround - been a hectic week!
It doesn't sound like there's any reason to wait merging this, as long as you're confident everything (that worked previously) is still working. Right?
I believe everything is still working! I manually tested the download dropdown, the plugin pane, and the mobile nav, which are the only components of the site that rely on JS. I tested on Chrome/Firefox on macOS, so YMMV?
By the way: have you checked out https://imagej.github.io?
Oh, I have not, but this looks cool! Very exciting, especially giving the wiki a facelift 😊
As for integrating the content on this page, I think long-term it may make sense (though I'm curious, what would you do with the fiji.sc
domain?). If that is the case, I'm happy to see what I can do to help with that as well.
I'm curious, what would you do with the fiji.sc domain?
@mattxwang I think we want to continue serving a front-facing site about Fiji from this domain, although I suppose we could instead just do a simple redirect. As a software engineer, of course I don't like maintaining "duplicate" content, but the reality is that ImageJ and Fiji are two different-but-related "brands" and both sites probably need to continue existing. But we're certainly in the process of stealing the cool stuff from the fiji.sc front page for use on the imagej.net front page—particularly the featured plugins block.
That sounds like a good plan to me, the branding dilemma makes sense.
But we're certainly in the process of stealing the cool stuff from the fiji.sc front page for use on the imagej.net front page—particularly the featured plugins block.
Glad to see it's being used elsewhere! Do let me know if you need any help migrating that over, hopefully this PR (removing jQuery) makes that even easier 😊
Hello,
Bootstrap V5 stable was just released today. This PR swaps out the minimum code possible for us to switch to Bootstrap 5 (which no longer uses jQuery), but otherwise leaves the code untouched.
You can preview the PR here.
The big picture changes:
To quickly outline the code-focused migration changes:
mr
formargin-right
- changes those tome
(margin end)jumbotron
is removed; replaces it with the utilities construction$()
selector behaviour to usedocument.getElementById
$.get
to usefetch()
data-bs-*
js actions for the download dropdown, plugins pane.sr-only
to.visually-hidden
aria-label
androle
attributes when desiredI also noticed that the search bar doesn't work properly for me, but this issue is also on the live site for me - so I don't think that's a regression in this PR.
Let me know what y'all think! More than happy to swap things around, and there's no rush - Bootstrap did just release the stable v5!
(closes #14).