search

fiji / fiji.github.io

Fiji website
https://fiji.sc
35 stars 11 forks source link

Client OS not properly identified by javascript for download option. #9

Closed turekg closed 4 years ago

turekg commented 4 years ago

In some cases (Firefox for Ubuntu Linux) the OS is not recognized and the user gets "Fiji is not currently supported on your OS" message. A discussion of this problem can also be found on the forum at https://forum.image.sc/t/fiji-sc-website-greets-with-fiji-doesnt-currently-support-your-os-on-supported-os/26239.

turekg commented 4 years ago

The issue stems from the fact that the script employed to make the OS determination uses "navigator.appVersion" which often will contain OS info along with version information, but this is not guaranteed. A better approach is to use "navigator.userAgent". I will fix this and submit a pull request

carandraug commented 4 years ago

I'm having the same issue. The appVersion returns the version information of the browser and no information about the OS.

But whatever fix is done about this, I think the displayed message in case OS identification fails should also be changed. Currently, it says "Fiji doesn't currently support your OS". Instead, it should say something like "Failed to identify your OS" and maybe offer to download the no-JRE version.

ctrueden commented 4 years ago

I think the displayed message in case OS identification fails should also be changed.

@carandraug I agree. With 19b8e2444034bcdbd913ae08ec837a842d7f476f I changed it to this:

Screen Shot 2019-09-10 at 10 20 59

Still plenty of room for improvement, but at least user isn't given a needless failure message.

carandraug commented 4 years ago

"Choose a download" is much better. Thank you for fixing this.