fiji / register_virtual_stack_slices

Fiji package for registering and transforming arbitrarily large sequences of images
https://imagej.net/Register_Virtual_Stack_Slices
GNU General Public License v3.0
18 stars 12 forks source link

Conflicting jhdf5 dependency entries? #13

Open mkitti opened 2 years ago

mkitti commented 2 years ago

Are both of these jhdf5 dependencies needed?

        <dependency>
            <groupId>ome</groupId>
            <artifactId>bio-formats_plugins</artifactId>
            <exclusions>
                <exclusion>
                    <!-- NB: Exclude problematic uber-JAR that bundles commons-io. -->
                    <groupId>ch.systems.cisd</groupId>
                    <artifactId>jhdf5</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <!-- NB: Needed by Bio-Formats. -->
            <groupId>cisd</groupId>
            <artifactId>jhdf5</artifactId>
            <scope>runtime</scope>
        </dependency>
mkitti commented 2 years ago

@ctrueden @sbesson this looks like legacy holdover code. Can we edit this down?

sbesson commented 2 years ago

@mkitti re-reading the commit message https://github.com/fiji/register_virtual_stack_slices/commit/372cd0600ae4073acdd65a6c336795b03cc6a59b, I think this exclusion was probably superfluous since Bio-Formats 6.1.0 where the jhdf5 dependency was upgraded with the cisd groupId. :+1: from my side

mkitti commented 2 years ago

I think we can remove the entire block then.