search

fikaproductions / fika-gatsby-source-cockpit

This is a Gatsby version 2.\*.\* source plugin that feeds the GraphQL tree with Cockpit Headless CMS collections and singletons data. Actually, it supports querying raw texts (and any trivial field types), Markdown, images, galleries, assets, sets, repeaters, layout(-grid)s (currently only without nested images/assets), objects, linked collections and internationalization.
GNU General Public License v3.0
23 stars 22 forks source link

External Link should not be included as asset link #7

Closed tecky-dev closed 5 years ago

tecky-dev commented 5 years ago

The current implementation of the code would regard any external link as an asset and attempt to replace it with the asset path. I propose to ignore any HTTP started link to avoid external link to be treated as asset.

WhippetsAintDogs commented 5 years ago

Hi @tecky-dev, ignoring any HTTP started link is unnecessary since if no corresponding asset is found from Cockpit, it automatically falls back to an external link (since version 1.0.8, with @aequi42's fix). However, good catch for the empty galleries and images. Could you edit your PR keeping only the c7f23f3 commit ? Thanks :)