search

fikovnik / ShiftIt

Managing windows size and position in OSX
5.54k stars 360 forks source link

Add some great new features for ultra wide monitors #311

Closed allanragec closed 4 years ago

allanragec commented 4 years ago

Add some great new features for ultra wide monitors:

Divided by 6

Screen Shot 2020-06-04 at 23 43 59

Divided by 3

Screen Shot 2020-06-04 at 23 43 21

Jun-04-2020 23-34-46

fikovnik commented 4 years ago

Thanks a lot! I don't know if you have seen https://github.com/fikovnik/ShiftIt/issues/296, but I no longer use OSX so I cannot even test this. If you want I could add you to the project if you would like to take over.

allanragec commented 4 years ago

@fikovnik Yeah, I saw that, I sorry about it. I'm using ShiftIt app for a long time and I can't imagine myself without this app. Instead to pay for other apps to have these features, I preferred to send this PR to have it and I'm loving to use these new features in my local machine. Would be a honor to be a maintainer :D

sposmen commented 4 years ago

@fikovnik would be great a new maintainer like @allanragec ... I also use it in the MacOS 10.15.x versions and this new feature would be awesome too in my 43" monitor. 🙏🏻

fikovnik commented 4 years ago

Indeed it would! I have just sent @allanragec an invite to the repo! Thanks a lot!

allanragec commented 4 years ago

@fikovnik do you think it is ready to merge it ? or can we wait a bit more for @rca review

fikovnik commented 4 years ago

go for it :-)

On Wed, Jun 10, 2020 at 6:56 PM Allan Melo notifications@github.com wrote:

@fikovnik https://github.com/fikovnik do you think it is ready to merge it ? or can we wait a bit more for @rca https://github.com/rca review

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fikovnik/ShiftIt/pull/311#issuecomment-642135964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC3PEVEHYWHEUFSUDT53QTRV63NLANCNFSM4NTFCYEQ .

rca commented 4 years ago

From the screenshot, this looks great; I can make use of this myself.

I took a very cursory look at the code, but am curious whether the new locations have keyboard shortcuts as well?

allanragec commented 4 years ago

@rca the default locations are: image

hbto commented 4 years ago

@allanragec awesome work

gsingh93 commented 3 years ago

Can a new release be created which includes this PR?

JaKXz commented 3 years ago

@allanragec or @rca sorry to ping out of the blue on a closed PR, but yeah would love to see a new version published with this cool stuff! :)

Antiavanti commented 3 years ago

@allanragec sorry to ping out of the blue on a closed PR, but yeah would love to see a new version published with this cool stuff! :)

@allanragec I came here to put the same question, could you create a new release 1.6.7 from current master? I think this PR is definitely worth to be released as soon as possible, because since last release from 2018 this one is a game changer, no doubts :)