filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 27 forks source link

:before and :after pseudo selectors #11

Closed NerdCowboy closed 9 years ago

NerdCowboy commented 9 years ago

It appears that before or after pseudo selectors won't be read if you use single colons (e.g. :before and :after instead of ::before and ::after). I tried adding single colon selectors in the forceInclude and it also wouldn't take unless I made it a double colon.

I realize that double colons are the preferred syntax moving forward, so I'm going to update my code in the mean time. However, I know I'm still in the habit of writing them with single colons and assuming some folks will still need to support IE8, so it might be a good idea to allow them.

jefflembeck commented 9 years ago

Very interesting. I'll put together a test case for https://github.com/filamentgroup/criticalcss, but this is likely a PhantomJS issue. We'll see what we can do to get around it!

jefflembeck commented 9 years ago

Should be fixed in 0.4.4