search

filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 26 forks source link

Shorthand CSS expands #24

Closed gvinson closed 1 year ago

gvinson commented 9 years ago

It looks like criticalcss is expanding some properties when using shorthand css. For example, 

background:url(image.jpg) 50% 0 no-repeat #fff;
-moz-background-size:cover;
-o-background-size:cover;
-webkit-background-size:cover;
background-size:cover;

becomes

background-image: url(image.jpg);
background-attachment: initial;
background-origin: initial;
background-clip: initial;
background-color: rgb(255, 255, 255);
-webkit-background-size: cover;
background-size: cover;
background-position: 50% 0px; 
background-repeat: no-repeat no-repeat;

I was just wondering if this was done on purpose, and if so, why.

Thanks!

jefflembeck commented 9 years ago

So, this is actually an issue with PhantomJS 1.x.

This issue will be resolved when we upgrade to Phantom 2.

I've flagged this in the criticalcss repo - https://github.com/filamentgroup/criticalCSS/issues/31