search

filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 27 forks source link

vh ( and probably vw ) support #30

Closed strukove closed 1 year ago

strukove commented 9 years ago

Hey, For some reason compiler doesn't want to add vh to critical.css. But if you change vh to pixels or something else - it works as expected. I even tried remove all styles from selector and leave only height:100vh (100.0vh) and add to to forceInclude array but it didn't help.

jefflembeck commented 9 years ago

We should probably add a test for this, but my best guess is that this is a problem with phantomjs 1.9. Once we upgrade to 2 (once https://github.com/Medium/phantomjs/issues/288 is closed), we should see a huge bump in things that we can do.

strukove commented 9 years ago

Okay. Thanks Jeff) Hope it's only pahntomjs 1.9 problem)

BrianWalters commented 8 years ago

Same thing happens with flex properties. Need that 2.0.

HugoHeneault commented 8 years ago

I need vh so much... :'(

willhowlett commented 8 years ago

Experiencing the same, with VW/VH, Flex and Calc

FezVrasta commented 8 years ago

Same with PhantomJS 2.0.0

ericvalois commented 8 years ago

Any news for that bug?

jefflembeck commented 8 years ago

If it's still being encountered in newer versions, unfortunately - i'm not sure how best to fix it yet. We rely on Phantom 2.1's support for attributes.