search

filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 26 forks source link

Module no longer installs #33

Closed zenopopovici closed 9 years ago

zenopopovici commented 9 years ago

Since updating to latest NPM, the module no longer installs. It hangs at phantomjs install. Tested on 2 different machines.

➜  Netex git:(develop) ✗ npm install grunt-criticalcss   

> phantomjs@1.9.13 install /Users/Zeno/Sites/Graffino/Box/Netex/node_modules/criticalcss/node_modules/phantomjs
> node install.js

Looks like an `npm install -g`; unable to check for already installed version.
Download already available at /var/folders/jg/dw8hwtn10cn8nyf25mr4yv700000gn/T/phantomjs/phantomjs-1.9.8-macosx.zip
Extracting zip contents
Removing /Users/Zeno/Sites/Graffino/Box/Netex/node_modules/criticalcss/node_modules/phantomjs/lib/phantom
Copying extracted folder /var/folders/jg/dw8hwtn10cn8nyf25mr4yv700000gn/T/phantomjs/phantomjs-1.9.8-macosx.zip-extract-1443018003805/phantomjs-1.9.8-macosx -> /Users/Zeno/Sites/Graffino/Box/Netex/node_modules/criticalcss/node_modules/phantomjs/lib/phantom
jefflembeck commented 9 years ago

npm 3.3.3? Which version of Node? Which OS?

zenopopovici commented 9 years ago

Sorry ... bug was rushed. I appologise:

Node v4.1.0 NPM: 3.3.4 / 3.3.3 (tried both) OSX: 10.10 / 10.11 (tried both)

gvinson commented 9 years ago

What was the fix to this? Does it simply take forever?

zenopopovici commented 9 years ago

I'm guessing they're looking at it. It's still open. There's no workaround.

jefflembeck commented 9 years ago

Will look at this today to see if I can find a quick fix.

jefflembeck commented 9 years ago

Ok, this seems to be working now in v0.6.0, let me know if you have any other issues!

fipp commented 8 years ago

jeff: do you know what specifically was changed in order to fix this?