search

filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 27 forks source link

Copying extracted folder stuck because of PhantomJS #34

Closed gijsroge closed 8 years ago

gijsroge commented 8 years ago 
Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-macosx.zip
Saving to /var/folders/rw/5lfpntc96k51n_dqkwx6_gln3hpdtt/T/phantomjs/phantomjs-1.9.8-macosx.zip
Receiving...
  [===========-----------------------------] 26% 0.0s
Received 9187K total.
Extracting zip contents
Removing /Applications/MAMP/htdocs/rolutex/web/theme/rolutex/node_modules/phantomjs/lib/phantom
Copying extracted folder /var/folders/rw/5lfpntc96k51n_dqkwx6_gln3hpdtt/T/phantomjs/phantomjs-1.9.8-macosx.zip-extract-1443086258120/phantomjs-1.9.8-macosx -> /Applications/MAMP/htdocs/rolutex/web/theme/rolutex/node_modules/phantomjs/lib/phantom

This is only happens if I include grunt-criticalcss. Without this module PhantomJS installs fine. I'm guessing this is because i'm using npm 3.3.3 which shares modules instead of the old inception way of including modules.

zenopopovici commented 8 years ago

I've reported the same issue here: https://github.com/filamentgroup/grunt-criticalcss/issues/33

gijsroge commented 8 years ago

See #33