search

filamentgroup / grunt-criticalcss

Grunt wrapper for criticalcss
MIT License
530 stars 27 forks source link

PhantomJS dependency causing npm install to hang? #35

Closed ghost closed 8 years ago

ghost commented 8 years ago

I have noticed the version of PhantomJS Critical CSS uses is 1.9.7, yet 1.9.8 and 2.0.0 are available.

Is this just me? I have cleared all global packages, and npm cache.

Once I remove Critical CSS from my package.json everything installs.

:expressionless:

Node versions tried: 4.2.2, 5.0.0 NPM version 2.14.7 MAC OSX Yosemite 10.10.5

jefflembeck commented 8 years ago

So, v0.6.1 of criticalcss installs the minimum phantomjs installer version of 1.9.17 - and that installs phantomjs 1.9.8.

$ ./node_modules/.bin/phantomjs --version
1.9.8

That being said, I just tried this on node 4.2.2 with npm version 2.14.7 on a clean project and it worked perfectly.

I've seen issues with downloading phantomjs in the past, and it's getting to be a problem for us overall. It's normally a proxy issue, etc. We've been waiting for them to upgrade to 2.0, but that doesn't look like it's going to happen.

I think we might have to remove the installer as a dependency and have a properly installed version of phantomjs as an external dependency soon. /cc @scottjehl

ghost commented 8 years ago

Actually it was me...

For some reason in my package.json I was looking for:

"grunt-critical-css": "*"

When it's:

"grunt-criticalcss": "*"

:no_mouth: