filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

Update jquery to version 3.0.0 🚀 #205

Closed greenkeeperio-bot closed 8 years ago

greenkeeperio-bot commented 8 years ago

Hello lovely humans,

jquery just published its new version 3.0.0.

State Update :rocket:
Dependency jquery
New version 3.0.0
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of jquery. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project :sparkles:

You rock!

:palm_tree:


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? :zap: greenkeeper upgrade

daedam commented 8 years ago

It looks like the bind and unbind functions have been deprecated in jQuery 3.0. Any calls to bind in the plugin code should also be changed to on (and unbind to off) to make sure that everything remains compatible.

https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryfnbind-is-deprecated

zachleat commented 8 years ago

Fixed.