search

filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

extraPaddingPixels (20px) might be unnecessary #209

Closed jaichandra closed 8 years ago

jaichandra commented 8 years ago

The 20px extraPaddingPixels value can hide a complete column (even when there is sufficient room), if there are more columns in table. I think this should not be hardcoded in the library, rather should be part of the table css.

tables.swipetoggle.js
Line 187: sum += headerWidths[ index ] + ( isPersist ? 0 : extraPaddingPixels );
jaichandra commented 8 years ago

pull request: https://github.com/filamentgroup/tablesaw/pull/210

zachleat commented 8 years ago

Fixed with #210

Thank you!