search

filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

Add basic support for colspan in data cells #225

Closed jgibson closed 8 years ago

jgibson commented 8 years ago

Currently the toggling algorithm doesn't take into account colspans in cells within the data. This behavior leads to toggling of incorrect columns when dealing with both wide headers and wide data.

This PR corrects that issue for the simple case where data can have a colspan that is not larger than its corresponding header nor does it cross any logical column boundaries.

Note that I wasn't sure if I should update the dist directory or not, so I left it unchanged. I can update if that's the appropriate workflow for this project.

toddparker commented 8 years ago

@zachleat - can you give this a look next week?

zachleat commented 8 years ago

@jgibson Thank you: this works great! And in so little code too! Really great work