search

filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

Fix for Column Toggle with Shoestring #260

Closed tomyouds closed 7 years ago

tomyouds commented 7 years ago

Shoestring does not support arguments being passed to the children function, which throws an error when using a Column Toggle Table

https://github.com/filamentgroup/shoestring/blob/55af278bead9468432b3ada49c8698203b34676d/src/dom/children.js#L12

tomyouds commented 7 years ago

@zachleat do you have any feedback on this?

zachleat commented 7 years ago

👍 Looks great—thanks!