filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

lint errors #310

Closed lschatzkin closed 6 years ago

lschatzkin commented 7 years ago

I'm on a team that always uses gulp-eslint to check our js files. I like your code for tablesaw stack-only but it produces many lint errors and I had to spend a good deal of time cleaning it up and some of them I cannot resolve. I also checked tablesaw.stackonly.jquery.js with jslint.com, I was given a completely different chunk of errors. If I can't resolve these errors, I won't be able to use your code, which would be a shame.

zachleat commented 6 years ago

Well, we use prettier as part of our build so our output should conform to default prettier rules. I’m confused why you’re linting library code though? Surely you can’t expect all the library code you import to obey your own internal code style configurations. I’m going to close this, I don’t think it’s on us—sorry.