search

filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

minified files not tracked in repo. #318

Closed drogers98 closed 6 years ago

drogers98 commented 7 years ago

It looks like uglify, and cssmin is specified in the gruntfile, but no .min.js, or .jquery.min.js, or .min.css files are present in the distribution (/dist or /dist/stackonly) folder of the repo.

These successfully build locally using grunt cssmin, and grunt uglify, but is there a reason they are not being tracked in the repo by default?

Unsure of your exact workflow, but perhaps adding to the default grunt task? ie changing: grunt.registerTask('default', ['src', 'jshint', 'qunit', 'filesize']); to grunt.registerTask('default', ['src', 'jshint', 'qunit', 'filesize', 'cssmin', 'uglify']);

zachleat commented 6 years ago

Yes, fair question. I personally don’t like checking in minimized code into the repo because I don’t want people to just reference the tablesaw code directly in a script tag. It’s kind of a weak incentive to concat and build it to something better for users.

The reason I have uglify in the workflow at all is for file size reporting in the build:

image

Please reopen if you want to make a case to change my mind 😀

drogers98 commented 6 years ago

Thanks for the explanation, makes sense to me, just wanted to make sure it wasn't an oversight is all. Cheers!