ava preset causing an issue with babel-loader

filamentgroup / tablesaw

A group of plugins for responsive tables.

MIT License

5.48k stars 434 forks source link

ava preset causing an issue with babel-loader #329

Closed francescozaia closed 6 years ago

francescozaia commented 6 years ago

Hey folks, Probably not an issue with this repo, but I need a pointer on an error that popped up after a recent tablesaw update. I created a repo here to let you quickly replicate the issue by simply running webpack on it.

This is the issue I am having:

ERROR in ./node_modules/tablesaw/dist/tablesaw.jquery.js
Module build failed: Error: Couldn't find preset "@ava/stage-4" ...

Any idea? Thanks

christian-fei commented 6 years ago

Having the same issue. Did you manage to resolve this issue @francescozaia ?

zachleat commented 6 years ago

I’m going to file this as a bug since our babel setup is wholly unnecessary for the ava testing tool.

zachleat commented 6 years ago

I released a 3.0.8-beta.1 to the beta release channel on NPM if you want to retest! https://preview.npmjs.com/package/tablesaw#versions

francescozaia commented 6 years ago

Yep, all good thanks! Pushed the fix on my test repo, in case anyone wants to check it out.

zachleat commented 6 years ago

@francescozaia thanks for confirming! 3.0.8 stable is out now with this change—thanks!