search

filamentgroup / tablesaw

A group of plugins for responsive tables.
MIT License
5.48k stars 434 forks source link

#342 Fix to allow tablesaw to work properly if loaded after the DOMContentLoaded event has fired #345

Closed porcus closed 5 years ago

porcus commented 6 years ago

This PR addresses the issue reported in #342.

In order to add unit tests for this, it was necessary to create a new html page. The new tests pass in modern browsers as long as they are served from an http server (but not from the file system).

This change is Reviewable

magicspon commented 6 years ago

Any chance this could get merged?

zachleat commented 5 years ago

Oh, interesting! I wonder if this PR could be modified to remove changes to dist/ files?

I want the test changes and the src changes and the README changes. But the dist stuff gets built for releases. (Sorry)

This will make testing and merging easier for me. Thank you!

zachleat commented 5 years ago

Merged in #359—thank you!

zachleat commented 5 years ago

v3.1.0 is out!

janfeldmann commented 5 years ago

I still had an issue inside version 3.1.2 when using webpack and the no dependency version. Tablesaw did not initialize properly. I resolved by calling the Tablesaw._init() instead of the default .init() function:

import('tablesaw').then((Tablesaw) => { Tablesaw._init(); }

Greetings Jan