search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.53k stars 2.98k forks source link

Wrong documentation about installation #10684

Closed yannisc closed 10 months ago

yannisc commented 10 months ago

Package

filament/tables

Package Version

v3.1.35

Laravel Version

v10

Livewire Version

v3.0

PHP Version

irrelevant

Problem description

Trying to add custom tailwind classes, I followed the installation guide here https://filamentphp.com/docs/3.x/tables/installation#configuring-your-layout and saw that the documentation is not accurate.

1) You should not create a new resources/views/components/layouts/app.blade.php file, but a resources/views/vendor/filament-panels/components/layout/base.blade.php file. 2) You should not paste in it the content shown in the documentation, but the content shown in the original file (vendor/filament-panels/components/layout/base.blade.php and add the line @vite('resources/css/app.css') underneath @filamentStyles.

Expected behavior

You should be able to add your new tailwind classes that are not currently compiled.

Steps to reproduce

If you follow the instructions in the current documentation, new tailwind classes are not read neither from app.css nor from any ->recordClasses() methods you may add.

Reproduction repository

-

Relevant log output

No response

github-actions[bot] commented 10 months ago

Hey @yannisc! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

yannisc commented 10 months ago

How should I send a wrong documentation issue?

tonypiper commented 7 months ago

@yannisc (and anyone else who finds themselves having this issue) it seems the fix is to follow the custom theme instructions at https://filamentphp.com/docs/3.x/panels/themes. It's not intuitive, because the filament docs talk about the livewire layout, and that includes vite directives, but that's not used to render a panel. Hope this helps!