filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.3k stars 2.96k forks source link

The table columns are not scrollable when there are a lot of columns to show/hide. #10888

Closed iyashpal closed 10 months ago

iyashpal commented 10 months ago

Package

filament/filament

Package Version

v3.2.2

Laravel Version

v10.41

Livewire Version

v3.3.5

PHP Version

PHP 8.2

Problem description

  1. I am working on a project and there is a resource that has a lot of table columns, and all are not required to be visible every time. So, I made some columns hidden but when I click on columns button the popup box goes out of the viewport and I am unable to scroll the hidden columns. This is happening in Resource Relation Manager table view.
Screenshot 2024-01-18 at 8 34 48 AM
  1. Second is it will be great if the columns popup/popover has a fixed height and can be scrollable all the time. The reason is when there are a lot of columns it creates the whole page scrollable with empty space below the table records. Screenshot 2024-01-18 at 8 51 53 AM

image

  1. When the dev tool is opened in Resource List View and the page scroll top is 0, the columns popup float placement goes to top and I am unable to scroll the columns, but when I scroll down popup float placement goes to bottom and I am able to see all the columns with the page scroll. Screenshot 2024-01-18 at 9 04 17 AM

Expected behavior

The table columns popup/popover should be scrollable every where.

Steps to reproduce

  1. Setup a table fields having 30+ columns.
  2. Setup the table fields in relation manager as well.
  3. Click on columns icon to check/uncheck the columns.

Reproduction repository

https://github.com/iyashpal/filamentphp-bug-reporting

Relevant log output

No response

danharrin commented 10 months ago

Please make a PR that adds a max height to the dropdown, and adds overflow-y-auto

danharrin commented 10 months ago

https://github.com/filamentphp/filament/pull/10902#issuecomment-1898709489