search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.13k stars 2.69k forks source link

Unpin fixed league/csv version #11213

Closed alepieser closed 6 months ago

alepieser commented 6 months ago

Package

filament/actions

Package Version

v3.2.23

Laravel Version

v10.0.0

Livewire Version

No response

PHP Version

PHP 8.2.0

Problem description

Hello,

There was a fix on filament/filament to unpin fixed league/csv version but the package filament/action has still the version pinned to 9.11.0.

Thanks

Expected behavior

To be able to upgrade league/csv to 9.14

Steps to reproduce

Check composer file

{ "name": "filament/actions", "description": "Easily add beautiful action modals to any Livewire component.", "license": "MIT", "homepage": "https://github.com/filamentphp/filament", "support": { "issues": "https://github.com/filamentphp/filament/issues", "source": "https://github.com/filamentphp/filament" }, "require": { "php": "^8.1", "anourvalar/eloquent-serialize": "^1.2", "filament/forms": "self.version", "filament/infolists": "self.version", "filament/notifications": "self.version", "filament/support": "self.version", "illuminate/contracts": "^10.0", "illuminate/database": "^10.0", "illuminate/support": "^10.0", "league/csv": "9.11.0", "openspout/openspout": "^4.23", "spatie/laravel-package-tools": "^1.9"

Reproduction repository

https://github.com/alepieser/filament_bug

Relevant log output

No response

github-actions[bot] commented 6 months ago

Hey @alepieser! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take.

github-actions[bot] commented 6 months ago

Thank you for providing reproduction steps! Reopening the issue now.

danharrin commented 6 months ago

done

danharrin commented 6 months ago

Gonna need to revert, its causing imports not to run