search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.3k stars 2.97k forks source link

JavaScript errors when both SPA and table defer loading are enabled #11371

Closed jalilfahimi closed 8 months ago

jalilfahimi commented 9 months ago

Package

filament/filament

Package Version

v3.2.31

Laravel Version

v10.43.0

Livewire Version

v3.4.4

PHP Version

PHP 8.3

Problem description

I am recieving js errors in console when both spa and table defer loading are enabled. I have noticed that these errors are triggered only once after a hard reload has happened. For second time visiting the same table, errors are gone.

errors.log

Expected behavior

--

Steps to reproduce

First, you need to enable spa in your panel panel() with calling ->spa(). Then, in a resource, call ->deferLoading() in the form() function. Finally, reload the list page of that resource.

Reproduction repository

https://github.com/jalilfahimi/filamentphp

Relevant log output

No response

github-actions[bot] commented 9 months ago

Hey @jalilfahimi! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

github-actions[bot] commented 9 months ago

Thank you for providing reproduction steps! Reopening the issue now.

danharrin commented 9 months ago

No reproduction repo

jalilfahimi commented 9 months ago

@danharrin Hey Dan, sorry for the wrong repo. reproduction repo is now edited.

danharrin commented 8 months ago

I am unable to reproduce the issue with the latest Livewire version

https://github.com/filamentphp/filament/assets/41773797/12158cff-c222-437e-83c8-f31da7543ad9