search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.13k stars 2.69k forks source link

Textarea should not pass submit on return #12026

Closed mischasigtermans closed 5 months ago

mischasigtermans commented 5 months ago

Package

filament/forms

Package Version

v3.2.54

Laravel Version

v10.48.3

Livewire Version

v3.4.9

PHP Version

PHP 8.3.3

Problem description

Currently textareas pass submit to the form on return. screenshot-001446 (2024-03-25)

Expected behavior

By default textareas should accept returns without submitting the form. More info on this here.

Steps to reproduce

Add a textarea to any form, hit return. @danharrin you can try on the create appointment modal on Stagent, it has the description textarea. For other modals we added a temp. fix.

Reproduction repository

https://github.com/getstagent/app

Relevant log output

No response

zepfietje commented 5 months ago

Assigning to @danharrin as I can't access the reproduction repository. Ideally provide an openly available repo, @mischasigtermans.

mischasigtermans commented 5 months ago

It's as easy as adding a textarea to any form to reproduce tho.

zepfietje commented 5 months ago

It's as easy as adding a textarea to any form to reproduce tho.

Nope it's not, I can't reproduce it.

dissto commented 5 months ago

It's as easy as adding a textarea to any form to reproduce tho.

Nope it's not, I can't reproduce it.

https://github.com/filamentphp/filament/assets/11778632/4653a51a-c49f-43b0-a461-0b6e52eb6d05

I am also not able to reproduce it

zepfietje commented 5 months ago

Thanks for double-checking, @dissto. Closing this until a public reproduction repository is provided.