filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
15.94k stars 2.54k forks source link

Actions -> ActionsPosition::BeforeColumns not work as expected when using Collapsible content #12580

Closed xmannv closed 2 months ago

xmannv commented 2 months ago

Package

filament/tables

Package Version

latest

Laravel Version

v10.48.10

Livewire Version

No response

PHP Version

PHP 8.3

Problem description

When using Table Collapsible content, the param ActionsPosition::BeforeColumns for Actions did not work as expected. It was still at the end of each row

Expected behavior

It should be stay at the beginning of each row

Steps to reproduce

return $table
            ->columns([
                Split::make([
                    TextColumn::make('name')
                        ->weight(FontWeight::Bold)
                        ->searchable()
                        ->sortable(),
                ]),
                Panel::make([
                    Stack::make([
                        TextColumn::make('email')
                            ->icon('heroicon-m-envelope'),
                    ]),
                ])->collapsible(),
            ])
            ->filters([
                //
            ])
            ->actions([
                ActionGroup::make([
                    Tables\Actions\EditAction::make(),
                    Tables\Actions\DeleteAction::make(),
                ]),
            ], position: ActionsPosition::BeforeColumns)
            ->bulkActions([
                Tables\Actions\BulkActionGroup::make([
                    Tables\Actions\DeleteBulkAction::make(),
                ]),
            ]);

Reproduction repository

https://github.com/xmannv/filament-bug-report

Relevant log output

No response

github-actions[bot] commented 2 months ago

Hey @xmannv! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

github-actions[bot] commented 2 months ago

Thank you for providing reproduction steps! Reopening the issue now.

dmitry-udod commented 2 months ago

@xmannv Hi! It seems the bug exists. I can reproduce your problem.

https://github.com/filamentphp/filament/assets/4639175/6141524b-11a8-4a2d-b3e7-207afb5a65b3