type hinting fix

[juliangums]

Package

filament/filament

Package Version

latest

Laravel Version

latest

Livewire Version

No response

PHP Version

latest

Problem description

Type hinting here seems wrong: https://github.com/filamentphp/filament/blob/3.x/packages/widgets/src/StatsOverviewWidget/Stat.php#L156

As it is different to this: https://github.com/filamentphp/filament/blob/3.x/packages/widgets/src/StatsOverviewWidget/Stat.php#L16

Also, I think it should really be using array<scalar|null, scalar|null> | null to allow all options possible. It's especially annoying as PHPStan will throw an error if I use floats.

Let me know if you're happy @danharrin and I can submit a PR.

Expected behavior

correct type hinting

Steps to reproduce

read the type hinting

Reproduction repository

https://github.com/juliangums/filament

Relevant log output

No response

[github-actions[bot]]

Hey @juliangums! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take.