search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.02k stars 2.68k forks source link

Valid nested headings #13295

Open zepfietje opened 2 months ago

zepfietje commented 2 months ago

Currently the section component uses <h3> for its headings. Similarly, table headings use <h4>.

In reality, people use nested sections and tables may be top-level components. I think it's time for Filament to support dynamically rendering the right heading element to produce valid HTML.

Not sure how feasible this is, but just wanted to create this issue for discussion, @danharrin.

Donate 💰 to fund this issue

Fund with Polar

danharrin commented 2 months ago

Related https://github.com/filamentphp/filament/discussions/13310

zepfietje commented 2 months ago

Would releasing this as a bug fix in v3 be too breaking? I mean, people might directly target the heading HTML elements in their custom CSS (hence I added the v4 milestone).

danharrin commented 2 months ago

Yeah I think we should do v4