search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.6k stars 2.75k forks source link

Missing action.php translations #1338

Closed luilliarcec closed 2 years ago

luilliarcec commented 2 years ago

Package

filament/filament

Package Version

v2.9.9

Laravel Version

v8.80.0

Livewire Version

v2.10.1

PHP Version

PHP 8.1

Bug description

I am testing the package, and I see that when I delete a resource, a modal appears, but the cancel button does not show the "Cancel" message, but a translation path, this happens when my application uses the "es" language. I was seeing that in the "feature: Page action modals" commit, it introduces a new file "lang/en/pages/actions.php" however that file is not found in the other translations. I would be happy to make a pull request with the Spanish translation, but unfortunately I could not do it for the other languages.

Steps to reproduce

No response

Relevant log output

No response

danharrin commented 2 years ago

Hey, I don't regard missing translations as a "bug" really - they're all community-contributed and Filament is not responsible for keeping them up to date - that would be a huge task and we do not have the resources to fix every string for every language.

Please submit a PR if you find something missing in your language :) That would be much appreciated.