filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.97k stars 2.93k forks source link

hiddenWhenAllChildComponentsHidden() goes into infinite recursion #13476

Open Skullbock opened 4 months ago

Skullbock commented 4 months ago

Package

filament/infolists

Package Version

v3.2.92

Laravel Version

v11.13.0

Livewire Version

v3.5.1

PHP Version

v8.3.2

Problem description

When using Infolist sections (or even forms) and adding the hiddenWhenAllChildComponentsHidden() call, the system goes into infinite recursion. This is because the steps are:

Not sure if the fix is simply calling getChildComponentContainers(withHidden: true) or if that has some other implications.

Expected behavior

It should not go in infinite loop.

Steps to reproduce

Reproduction repository (issue will be closed if this is not valid)

https://github.com/Skullbock/filament-issue-hidden

Relevant log output

No response

Donate 💰 to fund this issue

Fund with Polar

KhairulAzmi21 commented 4 weeks ago

Hi @Skullbock , did you find any workaround for this ?

Skullbock commented 4 weeks ago

@KhairulAzmi21 no, i had to check every child component manually