Performance issue with table

Tryfciu commented 1 month ago

Package

filament/filament

Package Version

v3.2.94

Laravel Version

v10.48.16

Livewire Version

v3.5.4

PHP Version

PHP 8.2

Problem description

Hey! Yesterday we managed to bump versions in our application (v3.2.73 -> v.3.2.94) and we encountered strange performance drop with table component. After version bump in some cases our table load time jumped from couple of seconds to 20-30 seconds. To be fair, our table is huge (100 records, 12 columns, 20+ filters), and it already had some issues with performance but we solved some of them and were happy. I run some performance tests to find out what is going on and this is the result.

Before version bump

After version bump

It looks like watchForCheckboxClicks method takes enormous amount of time to do the work. There was a discussion about possible performance but as far as I understand there were no changes made.

LINKED PR https://github.com/filamentphp/filament/pull/13074

Expected behavior

We would like the table to load in the same amount of time it did before or at least in bearable time. In the linked PR there was an idea to let user manage this feature on/off and it would be superb for us.

Steps to reproduce

In provided repository:

run seeder (2000 users)
go to http://127.0.0.1:8000/examples/list
apply email filter with any value
disable filter by pressing X in active filters section (yellow box)
application lags for a while (if you downgrade version under 3.2.87 - version with watchForCheckboxClicks then application run smoothly)
performance check for provided example

Reproduction repository (issue will be closed if this is not valid)

https://github.com/Tryfciu/filament-issue

Relevant log output

No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!