Pressing Enter/Return on an input in a Wizard will try to submit instead of going to the next step

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.

https://filamentphp.com

MIT License

18.97k stars 2.93k forks source link

Pressing Enter/Return on an input in a Wizard will try to submit instead of going to the next step #13779

Open mokhosh opened 3 months ago

mokhosh commented 3 months ago

Package

filament/filament

Package Version

v3.2.97

Laravel Version

v11.19.0

PHP Version

8.3.9

Problem description

Pressing Enter/Return on a text input in a Wizard will try to submit instead of going to the next step.

Expected behavior

It should just go to the next step.

Steps to reproduce

Create a two step Wizard for creating a model with two non-nullable attributes.
Put a text input in each step.
Press enter while the input in the first step is focused.
You will get a 500 error trying to create a model with null values.

Reproduction repository (issue will be closed if this is not valid)

https://github.com/mokhosh/filament-wizard-enter-bug

github-actions[bot] commented 3 months ago

Hey @mokhosh! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

mokhosh commented 3 months ago

@github-actions Hmm... I do have the reproduction repo.

https://github.com/mokhosh/filament-wizard-enter-bug

mokhosh commented 3 months ago

@danharrin not sure why the bot closed this

zepfietje commented 3 months ago

This is just default browser behavior, though I agree UX-wise it would be better to go to the next step on pressing enter. We'll have to investigate if this brings any accessibility issues though.

@dododedodonl, if I recall correctly, you mentioned this issue too.

mokhosh commented 3 months ago

@zepfietje yes it's not a bug, it's a ux issue. But a big one i would say if you consider the native os behaviour of wizards. We only understand this is normal because we know how we have tried to recreate the wizard experience with html, but end users will be very confused.