filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.21k stars 2.96k forks source link

Broken sticky topbar in `v4.x` #13881

Closed MartijnCuppens closed 2 weeks ago

MartijnCuppens commented 3 months ago

Package

filament/filament

Package Version

v4.x

Laravel Version

v11.20.0

Livewire Version

No response

PHP Version

PHP 8.3.0

Problem description

This only occurs in v4. The livewire component packages/panels/resources/views/livewire/topbar.blade.php wraps a <div> around the topbar. This breaks the sticky behaviour.

Expected behavior

Topbar should sticky to the top.

Steps to reproduce

You'll see it when your page is long enough and you scroll:

https://github.com/user-attachments/assets/308703b4-41ec-4fa5-87fa-2b21f299792a

Reproduction repository (issue will be closed if this is not valid)

https://github.com/MartijnCuppens/filament

Relevant log output

No response

Donate 💰 to fund this issue

Fund with Polar

github-actions[bot] commented 3 months ago

Hey @MartijnCuppens! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

github-actions[bot] commented 3 months ago

Thank you for providing reproduction steps! Reopening the issue now.

danharrin commented 2 weeks ago

ac9c31039b1fe7a03cc4091c5cea154ea46de709