search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.48k stars 2.73k forks source link

Docs improvement: collapsible method needs parameter in form section #1397

Closed bhupindersingh007 closed 2 years ago

bhupindersingh007 commented 2 years ago

Package

filament/filament

Package Version

v1.9

Laravel Version

v8.40

Livewire Version

No response

PHP Version

PHP 7.4

Bug description

Error occured, if no parameter is supplied to collapsible() method in form section ( specified in log output )

Docs : https://filamentadmin.com/docs/1.x/admin/forms#section ( parameter is no given in docs)

But, collapsible method works when have parameter like true.

Steps to reproduce

use collapsible method without any parameter

No response

Relevant log output

ArgumentCountError
Too few arguments to function Filament\Forms\Components\Section::collapsible(), 0 passed in F:\playground\projects\laravel-filament\app\Filament\Resources\CustomerResource.php on line 39 and exactly 1 expected

public function collapsible($collapsible)

    {

        $this->configure(function () use ($collapsible) {

            $this->collapsible = $collapsible;

        });

        return $this;

    }
danharrin commented 2 years ago

Hey, I am not actively working on v1 anymore, but would welcome any PRs to solve issues you are having.