filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.29k stars 2.96k forks source link

Bug-report project does not run out-of-the-box #14505

Closed MarkKremer closed 1 month ago

MarkKremer commented 1 month ago

Package

Other

Package Version

newest

Laravel Version

^11.9

Livewire Version

No response

PHP Version

^8.2

Problem description

When creating a bug report on Github (https://github.com/filamentphp/filament/issues/new), I'm given the following example project to base my reproduction on: https://filament-issue.unitedbycode.com/ This project does not work out-of-the-box even though the page states that it does and it could also be more user-friendly.

Expected behavior

A list of things I ran into while setting-up the project:

  1. The page states that the only requirement is to run php artisan serve. That is not the case. I also had to run:
    • php artisan key:generate
    • composer install?
    • php artisan migrate
    • php artisan db:seed or something else to create a user.
  2. The composer.json doesn't contain filament as a dependency, even though it's present in the vendor directory.
  3. The user that is pre-filled in the login form (App\Filament\Pages\Auth) does not match the seeded user.
  4. App\Providers\Filament\AdminPanelProvider isn't registered.
  5. http://127.0.0.1:8000/ shows the default Laravel app. This could redirect to the login form so I don't have to search for routes (which I couldn't find using php artisan route:list because they weren't registered).
  6. The README.md is the default Laravel README so it didn't help me with any of the above.

Steps to reproduce

  1. Create a bug report on https://github.com/filamentphp/filament/issues/new/choose.
  2. Click the link under "Reproduction repository" (https://filament-issue.unitedbycode.com/).
  3. Download and unzip the project.
  4. Run the project using php artisan serve.
  5. Go to http://127.0.0.1:8000/
  6. See that it doesn't work out-of-the-box.

Reproduction repository (issue will be closed if this is not valid)

https://github.com/MarkKremer/filament-pr-2

Relevant log output

No response

Donate 💰 to fund this issue

Fund with Polar

github-actions[bot] commented 1 month ago

Hey @MarkKremer! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

github-actions[bot] commented 1 month ago

Thank you for providing reproduction steps! Reopening the issue now.

danharrin commented 1 month ago

cc @ijpatricio

ijpatricio commented 1 month ago

Thanks for the heads up, I'll fix it and report back here.