Mitigate Carbon Month Overflow Bug on 31st of a month - Githubissues

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.

https://filamentphp.com

MIT License

19.47k stars 2.97k forks source link

Mitigate Carbon Month Overflow Bug on 31st of a month #14678

Closed PascaleBeier closed 3 weeks ago

PascaleBeier commented 3 weeks ago

Description

On the 31st of each month, the month selector for for the month filter breaks. The months retrieved in getMonths() will output:

January
March
March
May
May
July
July
August
October
October
December
December

To mitigate this, we set the day to the first day of the month.

Related Carbon Issues: https://github.com/briannesbitt/Carbon/issues/3097, https://github.com/briannesbitt/Carbon/issues/2317

Visual changes

none

Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

danharrin commented 3 weeks ago

Cheers, this is not an easy bug to reproduce every day is it!