search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.39k stars 2.97k forks source link

bug fix Infolist columns not respected on lg screen #14835

Closed uthadehikaru closed 3 days ago

uthadehikaru commented 3 days ago

Description

this pull request is to fix issue Infolist columns not respected on lg screen #14714

Functional changes

zepfietje commented 3 days ago

Thanks for contributing, @uthadehikaru! This isn't the right fix unfortunately.

Currently when passing an integer for columns, it only applies from screen size lg (which is by design). The issue (as described in the GitHub issue) occurs when passing an array. Please test your fix using the provided example and let me know if you need any feedback, happy to help :)

uthadehikaru commented 3 days ago

Thanks for contributing, @uthadehikaru! This isn't the right fix unfortunately.

Currently when passing an integer for columns, it only applies from screen size lg (which is by design). The issue (as described in the GitHub issue) occurs when passing an array. Please test your fix using the provided example and let me know if you need any feedback, happy to help :)

Hi @zepfietje thx for feedback. I tested using the scenario from the issue. Is there any case that I can do to solve this issue? Thx

zepfietje commented 3 days ago

If you could also test passing a single integer to the columns method and ensure that that still only applies from the lg breakpoint instead of sm (that this PR would change), that would help you find the final solution I think.