filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.39k stars 2.97k forks source link

Fix: Rely on Laravel's default job retry settings for Imports/Exports #14856

Open ahinkle opened 1 day ago

ahinkle commented 1 day ago

Description

This PR addresses an issue with the default retry behavior for failed imports, which can lead to unintended costs and resource usage. Specifically, the default behavior allows a bad import to continuously retry for 24 hours, potentially resulting in increased expenses due to services like AWS SQS and exception logging.

While the 24-hour retry window was designed to account for temporary issues like a database outage, it is more common for failures to result from code bugs or invalid data. Reducing the retry duration prevents these issues from escalating into excessive costs while still allowing jobs to retry a reasonable number of times.

We retain the existing method for those who prefer it while updating the default to align with your application (or Laravel's) defaults.

Fixes https://github.com/filamentphp/filament/discussions/13113 , https://github.com/filamentphp/filament/issues/10816

Functional changes