n+1 in MultiSelectFilter

[mohammadalizadeh10]

Package

filament/filament

Package Version

2.13.24

Laravel Version

9.19

Livewire Version

2

PHP Version

8

Bug description

hi, using MultiSelectFilter with relationship load all categories (where not working) and with option n+1 problem

Tables\Filters\MultiSelectFilter::make('category_id')
                    ->options(Category::where('type', Category::TYPE_CLUB)->get()->pluck('title', 'id')),

public function category(): BelongsTo
    {
        return $this->belongsTo(Category::class)
                    ->where('type', Category::TYPE_CLUB);
    }

Steps to reproduce

No response

Relevant log output

No response

[zepfietje]

@mohammad2306, could you set up a repository with the minimal code needed to reproduce the problem? This allows us to fix the issue much quicker.

[mohammadalizadeh10]

@zepfietje https://github.com/mohammad2306/filament-filter run php artisan migrate --seed and check category filter in news resource

[zepfietje]

@mohammad2306, this is not a bug. The many queries are caused by the filter options being retrieved internally. You should wrap your options query in a closure, and then it's fixed!

 Tables\Filters\MultiSelectFilter::make('category_id')
+    ->options(fn () => Category::where('type', Category::TYPE_NEWS)->get()->pluck('title', 'id')),
-    ->options(Category::where('type', Category::TYPE_NEWS)->get()->pluck('title', 'id')),