filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.86k stars 2.93k forks source link

Compatibility with blade-ui-kit/blade-heroicons 2.* #3916

Closed nocodelab closed 2 years ago

nocodelab commented 2 years ago

Package

filament/notifications

Package Version

2.0

Laravel Version

9.28.0

Livewire Version

2.10.7

PHP Version

8.1

Problem description

The dependency to blade-ui-kit/blade-heroicons should be updated to 2.* to support the new heroicons version (2).

Expected behavior

The installation should complete succesfully.

Steps to reproduce

composer require blade-ui-kit/blade-heroicons:"^2.0" composer require filament/notifications:"^2.0"

Reproduction repository

https://github.com/blade-ui-kit/blade-heroicons

Relevant log output

Problem 1
    - filament/notifications[v2.15.1, ..., 2.x-dev] require blade-ui-kit/blade-heroicons ^1.2 -> found blade-ui-kit/blade-heroicons[1.2.0, 1.2.1, 1.3.0, 1.3.1] but it conflicts with your root composer.json require (^2.0).
    - Root composer.json requires filament/notifications ^2.0 -> satisfiable by filament/notifications[v2.15.1, ..., 2.x-dev].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
ryangjchandler commented 2 years ago

@nocodelab This won't have until version 3.x of Filament because it's considered a breaking change for existing applications using renamed / removed icons in the new version of Heroicons.

zepfietje commented 2 years ago

Additionally, we can't upgrade to v2 of the Blade Heroicons package, since it dropped support for Laravel 8.

Closing this issue, as it's already being tracked on our v3 roadmap: https://github.com/orgs/filamentphp/projects/2/views/1.

danharrin commented 2 years ago

Reopening this so people stop asking

zepfietje commented 2 years ago

Done for v3: https://github.com/filamentphp/filament/issues/4490.