filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.86k stars 2.93k forks source link

Layout::BelowContent has been removed? #4167

Closed NicolasSacC closed 2 years ago

NicolasSacC commented 2 years ago

Package

filament/filament

Package Version

v2.16.13

Laravel Version

9.19

Livewire Version

No response

PHP Version

8.0.2

Problem description

This commit: https://github.com/filamentphp/filament/commit/f5f636f4bdd886105ac4ef759657bb3bba471889#diff-f55e230053254a9af4365cc0e5d9a1f8c6560892fe4f6be0863aa10cf3a4bf3f

Removed the constant BelowContent on Filters/Layout.

This is a breaking change and put errors on several of my pages.

Expected behavior

I didn't expect a breaking change to happen on a small version like that.

Steps to reproduce

N/A

Just see that in the commit, the constant was removed without a warning and this is a breaking change everywhere where Layout::BelowContent is used.

Reproduction repository

https://github.com/filamentphp/filament/commit/f5f636f4bdd886105ac4ef759657bb3bba471889#diff-f55e230053254a9af4365cc0e5d9a1f8c6560892fe4f6be0863aa10cf3a4bf3f

Relevant log output

No response

NicolasSacC commented 2 years ago

I didn't include a reproduction repository, I think that you can see why a bug would happen just by opening the commit.

danharrin commented 2 years ago

Whoops, let me check now...

danharrin commented 2 years ago

Fixed by https://github.com/filamentphp/filament/commit/3b276d2a827a1f3c01ea72c05895229c06f52adb

This has been released already

An explanation: I think that at one point, I added an additional BelowContent option for the Actions\Position class. Then I was unhappy with that wording and renamed it to AfterContent. I think that I might have used find and replace to do that, but didn't realise it was also an option for the Filters\Layout class. So I renamed everything at once. Sorry about that.