search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.12k stars 2.69k forks source link

Modal overlay covers modal scrollbar in Firefox 114 on Windows 10 #6773

Closed freshleafmedia closed 1 year ago

freshleafmedia commented 1 year ago

Package

filament/filament

Package Version

v2.17.43

Laravel Version

v9.52.7

Livewire Version

No response

PHP Version

PHP 8.1.20

Problem description

On Firefox 114 on Windows 10, if a modal that's taller than the browser window is active, the scrollbar is covered by the modal overlay, making it inaccessible. Using the scroll-wheel continues to work.

Screenshot of an active modal in the Filament demo instance where the modal scrollbar is covered by the modal overlay

Expected behavior

Modals that are taller than the browser window can be scrolled using the scrollbar.

Steps to reproduce

  1. In Firefox 114 on Windows 10, visit the Filament demo instance.
  2. Find a page with a modal, activate it, and resize the browser window so that it is smaller than the modal.

Reproduction repository

https://github.com/filamentphp/demo

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @freshleafmedia! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

zepfietje commented 1 year ago

Essentially same thing on macOS Safari, even though the scrollbar isn't persistent. Will look into this for v3.

zepfietje commented 1 year ago

I haven't found a way to make this work, so feel free to create a pull request if you know how to fix it. Since it's not a major bug, I'm keeping this issue closed.