search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
17.65k stars 2.76k forks source link

[2.x] getImagePath should be url encoded #737

Closed blite closed 2 years ago

blite commented 2 years ago

Package

filament/filament

Package Version

v2

Laravel Version

v8

Livewire Version

v2

PHP Version

PHP 8

Bug description

Currently if you have a ' in your image's path it will work for ImageColumn until you set ->rounded(), then the ImageColumn will not show.

I know this package by default / livewire renames files to random names, but if you have a ' in your path you will still get this error.

This is due to the correct quoting for -rounded() in https://github.com/laravel-filament/filament/blob/2.x/packages/tables/resources/views/columns/image-column.blade.php.

For me this is failing with bird names specifically: http://laravel.test/storage/images/Baird's_Sandpiper/Calidris_bairdii.jpg

Steps to reproduce

No response

Relevant log output

No response

karam-mustafa commented 2 years ago

"I know this package by default/livewire renames files to random names", Liveware shouldn't make a file name with a single or double quote, What steps did you follow to get this link?

danharrin commented 2 years ago

Fixed in #766.