filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.07k stars 2.83k forks source link

Form Select Use choices.js style.minWidth Error #7538

Closed killjin closed 1 year ago

killjin commented 1 year ago

Package

filament/forms

Package Version

3.0

Laravel Version

10

Livewire Version

3

PHP Version

8.2

Problem description

Form Select style.minWidth Bug.

choices.js

setWidth(): void {
    // Resize input to contents or placeholder
    const { style, value, placeholder } = this.element;
    style.minWidth = `${placeholder.length + 1}ch`;
    style.width = `${value.length + 1}ch`;
  }

style.minWidth ch units are problematic for non-english languages. Non-English languages may be 2ch per word.

Expected behavior

Non-English languages may be 2ch per word.

Steps to reproduce

Non-English languages may be 2ch per word.

Reproduction repository

https://github.com/filamentphp/filament

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @killjin! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.