filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.07k stars 2.83k forks source link

Unsave non translatable fields when make resource translatable V3 #7550

Closed MPTA closed 1 year ago

MPTA commented 1 year ago

Package

filament/spatie-laravel-translatable-plugin

Package Version

v3.0-stable

Laravel Version

v10.10

Livewire Version

v3.0@beta

PHP Version

PHP 8.2

Problem description

when make a resource Translatable , only non-translatable fields will update in edit form. even i override handleRecordUpdate() method and using $model->update($data), still updated non-translatable fields. after i remove Translatable Traits , it will work.

Expected behavior

must update all fields in $fillable array in model.

Steps to reproduce

as short as possible

Reproduction repository

https://github.com/filamentphp/spatie-laravel-translatable-plugin

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @MPTA! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take.