filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.07k stars 2.83k forks source link

Invalid tenant menu item dropdown panel stack order when sidebar collapsed #7577

Closed qoqn closed 1 year ago

qoqn commented 1 year ago

Package

filament/filament

Package Version

v3.0.12

Laravel Version

v10.17.1

Livewire Version

No response

PHP Version

8.2.8

Problem description

In multi tenant application, when using sidebarCollapsibleOnDesktop() option on panel and collapsing the sidebar in desktop the stack order is invalid, tenant menu items is inside (or behind?) the collapsed sidebar.

image

Expected behavior

Tenant menu (dropdown) should be above sidebar, viewable and clickable even on collapsed sidebar.

Steps to reproduce

Using this panel configuration, or the default tenantMenuItems() configuration (where the tenant selector exists)

return $panel
            // ... other settings
            ->sidebarCollapsibleOnDesktop()
            // ... other settings
            ->tenantMenuItems([
                MenuItem::make()
                    ->label('Settings')
                    ->icon('heroicon-m-cog-8-tooth'),
            ])
            // ... other settings

Reproduction repository

https://github.com/muoya

Relevant log output

No response

danharrin commented 1 year ago

No reproduction repo?

lamberttraccard commented 1 year ago

@danharrin could we reopen the issue please ? I have a made a reproduction repo https://github.com/lamberttraccard/filament-issue

lamberttraccard commented 1 year ago

Thanks 🙂

zepfietje commented 1 year ago

Fixed in https://github.com/filamentphp/filament/commit/cfe9d6067413525739ef9eaab89b54e017d302f2.