search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.98k stars 2.93k forks source link

Table::reorderable() - random shuffling #7873

Closed EvodiaAut closed 1 year ago

EvodiaAut commented 1 year ago

Package

filament/tables

Package Version

v3.0.25 (demo.filamentphp.com)

Laravel Version

10 (demo.filamentphp.com)

Livewire Version

No response

PHP Version

8.1 (demo.filamentphp.com)

Problem description

If you finish to sort a brand he start random shuffling all brands.

Expected behavior

A right sorting after sorting a brand (In version 2 works).

Steps to reproduce

Open https://demo.filamentphp.com/shop/brands?isTableReordering=true Drag first brand to second position and see what happens.

Reproduction repository

https://github.com/filamentphp/demo

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @EvodiaAut! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

pxlrbt commented 1 year ago

Dan, not sure if the demo is enough reproduction repo in this case. I'll reopen for now and you decide.

danharrin commented 1 year ago

Cannot reproduce locally though, only on the Live demo

pxlrbt commented 1 year ago

Old Livewire version?

zepfietje commented 1 year ago

Just updated dependencies on the demo and tested in production. Can't reproduce the issue anymore so seems to be fixed.

EvodiaAut commented 1 year ago

If you start sorting now, he load all items in one table? I don't think it was like that before.

It's need a lot of power for server and client by 400 items. Let's be 10.000 items its done with both 😅

danharrin commented 1 year ago

It is documented, it was a bug before the previous version. You can change that behaviour.

EvodiaAut commented 1 year ago

You mean https://filamentphp.com/docs/3.x/tables/advanced#enabling-pagination-while-reordering

Cool amazing, maybe you show this in the demo. Thanks for checking and clarification.