search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.28k stars 2.96k forks source link

Button badges being truncated to 1 character #8092

Closed saade closed 1 year ago

saade commented 1 year ago

Package

filament/filament

Package Version

v3.0.34

Laravel Version

10.20.0

Livewire Version

dev-main

PHP Version

8.2.9

Problem description

Button badges are being truncated to 1 character

image

Expected behavior

Badges should grow up to content length

Steps to reproduce

Action::make('changeStatus')
    ->label('Change status')
    ->icon('tabler-status-change')
    ->color('gray')
    ->badge('1225')
    ->outlined()

Reproduction repository

https://github.com/saade/filament-reproduction-repo

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @saade! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

saade commented 1 year ago

@zepfietje i don't think i need a repro repo for this, if you want one, let me know

github-actions[bot] commented 1 year ago

Thank you for providing reproduction steps! Reopening the issue now.

archilex commented 1 year ago

Hi @saade This is a result of PR #8018, but it's being worked on.

zepfietje commented 1 year ago

Thanks for reporting, @saade. I was aware of this issue and had already fixed it in https://github.com/filamentphp/filament/commit/b60c120771f80d59ef44ab00262ce64204c9b2a5.

However, no release has been tagged with that fix yet. @danharrin will probably tag a release after I've implemented a fix for another issue later today.

If you like, you can verify this issue has been fixed by pulling in 3.x (but I'm very sure it's fixed 😉).