filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
18.98k stars 2.93k forks source link

Resource sub-navigation should keep its own collapsed state #8755

Closed saade closed 11 months ago

saade commented 1 year ago

Package

filament/filament

Package Version

v3.0.62

Laravel Version

10.25.1

Livewire Version

v3.0.5

PHP Version

8.2.10

Problem description

Resource subnavigation is getting collapsed with the sidebar (which makes sense because it uses the same $store.sidebar.isOpen)

https://github.com/filamentphp/filament/assets/14329460/875c3d61-9c1b-4c11-89a7-9c1f2d308dff

Expected behavior

The subnavigation should not collapse with the sidebar

Steps to reproduce

Reproduction repository

https://github.com/saade/filament-issue-reproduction-repo

Relevant log output

No response

saade commented 1 year ago

@zepfietje should i add a real reproduction repo to this? seems pretty easy to reproduce as its just adding subnavigation to the page.

zepfietje commented 1 year ago

I think it's ok as is. Only @danharrin has worked on this so far. Still pending design review by me.

glennjacobs commented 11 months ago

I will attempt to solve this today/tomorrow.