search

filamentphp / filament

A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS.
https://filamentphp.com
MIT License
19.29k stars 2.96k forks source link

Wondering if border is needed in this icon ? #8941

Closed zenati closed 1 year ago

zenati commented 1 year ago

Package

filament/filament

Package Version

3.0.49

Laravel Version

10.10

Livewire Version

No response

PHP Version

8.1.0

Problem description

Screenshot 2023-10-07 at 13 08 30 Screenshot 2023-10-07 at 13 10 47

Small border design issue, in both dark/light modes. Is this a bug or intentional (in that case close the issue)? Thank you.

Expected behavior

No borders, or a different approach.

Steps to reproduce

BelongsToSelect with create/edit relation ship.

Reproduction repository

https://no-reproduction-repository.com

Relevant log output

No response

github-actions[bot] commented 1 year ago

Hey @zenati! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

zepfietje commented 1 year ago

This is caused by the focus states of both components. We're aware of this and planning to fix it.