filamentphp / filamentphp.com

Source code for the filamentphp.com website.
https://filamentphp.com
192 stars 258 forks source link

Plugin: List TomatoPHP Community Plugins #406

Closed 3x1io closed 5 months ago

3x1io commented 6 months ago

Hello, in this pull request, I meticulously reviewed and updated all dates, incorporating historical versions to ensure accuracy. The release date now reflects the initial creation of this package for v2 or v3. Apologies for the size of this pull request, but we'll proceed with subsequent updates individually after this one.

List of Plugins:

3x1io commented 5 months ago

Any updates?

megoxv commented 5 months ago

Why do you not approve with all these plugins that will greatly help the community? This is a developer who deserves appreciation and thanks for this great effort.

3x1io commented 5 months ago

@megoxv thanks for your support, I think it's the reviewing time as they say but, I think it's out of control with 4 weeks for review, but we can still wait for that.

saade commented 5 months ago

@megoxv You can still use the plugins even if they haven't been published on the website.

@3x1io The review process takes time, and neither of us work full-time for Filament; we have bills to pay; i review plugins once a week. If you look closely, other plugins were merged during that period. Your plugins got reviewed before, all of them had problems. As we've mentioned 3 or 4 times before, if you had submitted one PR per plugin, some of them might have been published by now. Be patient. They will be published by the end of this week if everything is correct.

3x1io commented 5 months ago

@saade thanks for the replay, it's okay I know that you are working hard, and thanks for your time and support, but I still have a lot of plugins to publish and because of this PR I can't move, so I'm sorry for pushing you, and have a nice time.

awcodes commented 5 months ago

In all honesty, even if it's an inconvenience on your part this would all have been easier and most of them could have been approved by now if you submitted each one individually. It might still be faster to do them individually at this point.

3x1io commented 5 months ago

@awcodes yes i know that, and i still have more plugins to publish and i will push it one by one after this PR

3x1io commented 5 months ago

@saade the last change only removed filament-browser from the list because of a security issue inside it, I fixed it but I will do some updates to the package and then resubmit it.

saade commented 5 months ago

Also, your channels on Discord are indistinguible, i'd rather use 3x1io-foo-plugin or tomato-foo-plugin. That's not a requirement, only a tip. If you want to use tomato-foo-plugin please setup an author profile for it and update the plugin slugs accordingly.

image

3x1io commented 5 months ago

All images inside plugins is jpg and on the resolution that you ask me to use, and i add a direct url on the readme

Check this

Screenshot

If it's on specific plugin please let me know

saade commented 5 months ago

All images inside plugins is jpg and on the resolution that you ask me to use, and i add a direct url on the readme

Check this

Screenshot

If it's on specific plugin please let me know

Right... you've submitted the wrong optimized images, i've removed them and generated again, the're ok now.

The only thing missing is the README images, you're not using the correct raw url:

You're using: https://github.com/tomatophp/filament-types/blob/master/arts/3x1io-tomato-types.jpg

When it should be: https://raw.githubusercontent.com/tomatophp/filament-types/master/arts/3x1io-tomato-types.jpg

Please make the changes and your plugins will be ready to be merged.

3x1io commented 5 months ago

@saade it's all done now all images have been fixed.